ilya-biryukov added a comment. In D64475#1602195 <https://reviews.llvm.org/D64475#1602195>, @jvikstrom wrote:
> In D64475#1593481 <https://reviews.llvm.org/D64475#1593481>, @ilya-biryukov > wrote: > > > The fix for a race condition on remove has landed in rL366577 > > <https://reviews.llvm.org/rL366577>, this revision would need a small > > update after it. > > > Fixed to work with that patch. > Should the diffing be moved somewhere else that is not inside the publish > function though? That would require moving the state outside the LSP server > though and handle the onClose/onOpen events somewhere else though. > Maybe it's ok to keep the diffing in the publish lock? Yeah, let's keep it in publish for now. Diffing in there does not change complexity of the operations. If it ever turns out that the constant factor is too high, we can figure out ways to fight this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
