ABataev added inline comments.
================ Comment at: lib/CodeGen/CGOpenMPRuntime.h:815 + /// code generation. + void emitUDMapperArrayInitOrDel(CodeGenFunction &MapperCGF, + llvm::Value *Handle, llvm::Value *BasePtr, ---------------- lildmh wrote: > ABataev wrote: > > Seems to me, this function is used only in `emitUserDefinedMapper`. I think > > you can make it static local in the CGOpenMPRuntime.cpp and do not expose > > it in the interface. > `emitUserDefinedMapper` needs to call `createRuntimeFunction` of > `CGOpenMPRuntime`, which is private. > > Which one do you think is better, make `createRuntimeFunction` public, or > have `emitUserDefinedMapper` not defined in `CGOpenMPRuntime`? It seems to me > that they are similar Then make `emitUDMapperArrayInitOrDel` private instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
