[PATCH] D65308: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd added inline comments.


================
Comment at: clang/lib/Driver/Types.cpp:113
+           Id == TY_HIP_FATBIN);
+// clang-format on
 }
----------------
I think this is better written as:

```
static const clang::driver::types::ID kStaticLangageTypes[] = {
  TY_CUDA_DEVICE, TY_HIP_DEVICE, ...
};
return !llvm::contains(kStaticLangageTypes, Id);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65308/new/

https://reviews.llvm.org/D65308



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits