Szelethus accepted this revision. Szelethus added a comment. LGTM, thanks! Please mark inlines as done as you fix them. If you like the file description I proposed, I'm happy to commit this on your behalf (or you might as well apply for a commit access, since you have a track record of high quality patches already).
================ Comment at: lib/StaticAnalyzer/Checkers/Yaml.h:9 +// +// This file contains a simple interface allow to open and parse yaml files. +// ---------------- Szelethus wrote: > Is this actually the reason why we have this file? We already have a YAML > parser in LLVM, what's does this file do that the "default" parser doesn't? I would appreciate some comments, it still isn't immediately obvious why we need yet another yaml file. How about "This file defines convenience functions for handling YAML configuration files for checkers/packages". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
