sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:399 + // FIXME: SelectionTree needs to be fixed for macros + /*{R"cpp(#define LOOP(x) while (1) {a = x;} void f(int a) { ---------------- can you uncomment this case, and assert the actual behavior? The FIXME should say what it should be instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits