plotfi marked an inline comment as done. plotfi added inline comments.
================ Comment at: clang/lib/Driver/Types.cpp:305 + P.clear(); + for (auto Phase : getInfo(Id).Phases) + P.push_back(Phase); ---------------- aaron.ballman wrote: > Can't you use the local `Phases` object instead of calling `getInfo()` again? > This seems like it wants to be `P = Phases;` Oh yeah sure. I can change that. Anything else pop out at you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64098/new/ https://reviews.llvm.org/D64098 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
