jvikstrom marked 2 inline comments as done. jvikstrom added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:179 + R"cpp( + template<typename $TemplateParameter[[T]], typename = void> + class $Class[[A]] { ---------------- hokein wrote: > hokein wrote: > > could you add some more test cases? > > > > - for unnamed template parameter, `template <typename> class Foo {};` > > - for partial template specialization > Looks like you are still missing the unnamed template parameter `template > <typename> class Foo {};` case Oh sorry, added it and landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64855/new/ https://reviews.llvm.org/D64855 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits