sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/Writer.cpp:400
+      StringRef name = segment->getName();
+      if (name.startswith(".tdata.") || name.startswith(".tbss."))
+        tlsUsed = true;
----------------
Right now we always compiler with -fdata-sections, but if we didn't then object 
files might have just one ".tdata" sections.   Perhaps drop the final "."?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64537/new/

https://reviews.llvm.org/D64537



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to