ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM (I think @hokein 's comments were addressed too) > So it seems to be expected. (and looking at the documentation for > InitListExpr it seems to be difficult to change RecursiveASTVisitor to visit > every sub expr once) Ah, this particular piece of behavior seems really surprising to me. We should definitely only traverse syntactic form if `shouldVisitImplicitCode() == true`, which should help us avoid this corner case here. But that's a topic for a separate patch, please land this to unbreak semantic highlighting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64634/new/ https://reviews.llvm.org/D64634 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
