ziangwan added a comment.

In D64666#1583633 <https://reviews.llvm.org/D64666#1583633>, @xbolva00 wrote:

> You can check also https://reviews.llvm.org/D52835. I hit there issue which I 
> didn't know how to solve.


Hi David,

I have read your patch. I think that integer-to-floating-point conversion does 
not necessarily leads to precision loss. We need to have extra condition about 
whether to issue warnings.

For example,

1. Convert 222222222222L to float leads to precision loss. The reason is that 
222222222222L needs 48 bits of precision where float only has 24 bits of 
precision.
2. Convert 222222 to float does not lead to precision loss. 222222 needs 18 
bits of precision only.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64666/new/

https://reviews.llvm.org/D64666



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to