xazax.hun marked an inline comment as done.
xazax.hun added a comment.
Thanks for the review! I will update the patch soon. As there is a dependency
that is not accepted yet Richard (who authored the code I extended) might have
some chance to take a look at this patch.
================
Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:25
+
+struct [[gsl::Owner(int)]] OwnerWithConv {
+ OwnerWithConv();
----------------
gribozavr wrote:
> Would be nice if the second pair of types had clearly related names, like the
> first pair (MyOwner/MyPointer).
Would renaming `MyPtrFromConv` to `PointerFromConv ` be enough to suggest the
relationship?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64256/new/
https://reviews.llvm.org/D64256
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
