aganea added a comment.

In D64301#1574304 <https://reviews.llvm.org/D64301#1574304>, @rnk wrote:

> I think @zturner wanted to teach lit to completely remove the Output/ 
> directory for every test so we don't have to deal with stale files from 
> previous tests hanging around. I remember objecting that we can't do that on 
> startup since it's slow and not parallelized. However, I think we could 
> probably add it as an early step to TestRunner.executeShTest so we don't have 
> to add these extra 'rm' commands anymore.


Just a reminder, the `DeleteFile` API, and thus `rm` on Windows are async. See 
this <https://devblogs.microsoft.com/oldnewthing/20120907-00/?p=6663>. 
Occasionally, the tests are failing locally on my PC because of that (maybe 1 
out of 50 times).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64301/new/

https://reviews.llvm.org/D64301



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to