[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.
Herald added a subscriber: wuzish.

I would write the following test (I can commit that for you)

  diff --git c/test/Driver/frame-pointer-elim.c 
w/test/Driver/frame-pointer-elim.c
  index 6fcd3eb75a..c2e9ccb225 100644
  --- c/test/Driver/frame-pointer-elim.c
  +++ w/test/Driver/frame-pointer-elim.c
  @@ -1 +1,3 @@
  +// DISABLE-FP-ELIM: "-mdisable-fp-elim"
  +
   // For these next two tests when optimized we should omit the leaf frame
  @@ -31,4 +33,3 @@
   // RUN: %clang -### -target i386-apple-darwin -S %s 2>&1 | \
  -// RUN:   FileCheck --check-prefix=DARWIN %s
  -// DARWIN: "-mdisable-fp-elim"
  +// RUN:   FileCheck --check-prefix=DISABLE-FP-ELIM %s
   
  @@ -71,2 +72,7 @@
   
  +// RUN: %clang -### -target powerpc64 -S %s 2>&1 | \
  +// RUN:   FileCheck --check-prefix=DISABLE-FP-ELIM %s
  +// RUN: %clang -### -target powerpc64 -S -O1 %s 2>&1 | \
  +// RUN:   FileCheck --check-prefix=OMIT_ALL %s
  +
   void f0() {}

but I don't understand why OpenBSD enabled frame pointer elimination in 
rL358775 <https://reviews.llvm.org/rL358775> then reverted it in rL364679 
<https://reviews.llvm.org/rL364679>. It is important to know whether OpenBSD 
needs frame pointer elimination.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60335/new/

https://reviews.llvm.org/D60335



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits