[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.

thanks, looks good.



================
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:52
       R"cpp(
-    struct A {
-      double SomeMember;
-    };
-    struct {
-    }   $Variable[[HStruct]];
-    void $Function[[foo]](int $Variable[[a]]) {
-      auto $Variable[[VeryLongVariableName]] = 12312;
-      A     $Variable[[aa]];
-    }
-  )cpp",
+      struct AS {
+        double SomeMember;
----------------
nit: I'd add 2-space to the code, like: 

```
R"cpp(
    struct AS {}
    ...
)cpp, 
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64199/new/

https://reviews.llvm.org/D64199



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits