nickdesaulniers added inline comments.
================
Comment at: clang/include/clang/Sema/AnalysisBasedWarnings.h:95
+ void flushDiagnostics(SmallVector<clang::sema::PossiblyUnreachableDiag, 4>);
+
----------------
Methods should be UpperCamelCased.
================
Comment at: clang/include/clang/Sema/AnalysisBasedWarnings.h:112
+ void
+ emitPossiblyUnreachableDiags(AnalysisDeclContext &AC,
+ SmallVector<PossiblyUnreachableDiag, 4> PUDs);
----------------
UpperCamelCase
================
Comment at: clang/lib/Sema/SemaExpr.cpp:16672
+ FunctionScopes.back()->PossiblyUnreachableDiags.push_back(
+ clang::sema::PossiblyUnreachableDiag(PD, Loc, Stmts));
return true;
----------------
does this need the `clang::` qualifier?
================
Comment at: clang/lib/Sema/SemaExpr.cpp:16701
+ AnalysisWarnings.RegisterVarDeclWarning(
+ VD, clang::sema::PossiblyUnreachableDiag(PD, Loc, Stmts));
+ return true;
----------------
does this need `clang::`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63889/new/
https://reviews.llvm.org/D63889
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
