lebedev.ri added a comment. In D63638#1560846 <https://reviews.llvm.org/D63638#1560846>, @spatel wrote:
> I skimmed D63174 <https://reviews.llvm.org/D63174> but haven't applied either > of these patches to test locally, so I may not have the full picture. > > IMO, we do not want clang regression tests running > -instcombine/-instsimplify. That can cause clang tests to break when an > underlying LLVM change is made. Forcing LLVM devs to depend on clang and fix > the resulting breakage is backwards and unexpected extra work. +1 > This has happened to me several times. > As a compromise to the -O0 IR explosion, we do have precedent for running the > optimizer's -mem2reg pass since that doesn't change frequently at this point. > > And I haven't tried this, but we do have utils/update_cc_test_checks.py - > this is supposed to take the manual labor out of generating assertions in the > same way that we do in the optimizer and codegen regression tests with > utils/update_test_checks.py and utils/update_llc_test_checks.py. Can you > start with that and remove the irrelevant CHECK lines, so only the > common/important lines remain? Or just use independent FileCheck > '--check-prefixes'? That script has bitrot and is unusable last time i checked; everyone preferred to manually write broken checklines here :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63638/new/ https://reviews.llvm.org/D63638 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
