DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added inline comments.
================ Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:106-107 + + std::string Buffer; + llvm::raw_string_ostream Members(Buffer); + if (!I.Members.empty()) ---------------- jakehehrlich wrote: > This is a generally bad pattern. Some of the uses of an intermediate ostream have been deleted but I consider that some are still useful. One of them is the when rendering the list of Enum Members, after generating a list of <li>'s, we require the intermediate ostream to put it between the ul tags. I consider that's better than: ``` OS << "<ul>\n"; for (...) OS << ...; OS << "</ul>\n"; ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63180/new/ https://reviews.llvm.org/D63180 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
