dexonsmith added a comment.

In D63048#1558806 <https://reviews.llvm.org/D63048#1558806>, @sylvestre.ledru 
wrote:
> @dexonsmith ping?


I think I'd be a little more comfortable dropping `__VERSION__` entirely.  
There's already a way to access the clang version, and anyone with code that 
relies on `"4.2.1"` can just add a `-D__VERSION__=...` to their build rules to 
keep existing behaviour.

FWIW, I feel similarly about `-dumpversion` (better to remove it than change 
it).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63048/new/

https://reviews.llvm.org/D63048



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to