torarnv added a comment.

In D63508#1550668 <https://reviews.llvm.org/D63508#1550668>, @rsmith wrote:

> Perhaps we should rewrite all `#if`-like directives to `#if 0` or `#if 1`?


If I understand your suggestion correctly, wouldn't the latter break this case?

  #if QT_HAS_INCLUDE(<nope.h>)
  #  include <nope.h>
  #  define HAS_NOPE
  #endif
  
  #ifdef HAS_NOPE
  void bar() { nope(); }
  #endif




Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63508/new/

https://reviews.llvm.org/D63508



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to