kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM with one more test case request. Thanks!
================
Comment at: clang-tools-extra/clangd/test/fixits-duplication.test:44
+---
+{"jsonrpc":"2.0","id":2,"method":"textDocument/codeAction","params":{"textDocument":{"uri":"test:///foo.cpp"},"range":{"start":{"line":0,"character":23},"end":{"line":0,"character":24}},"context":{"diagnostics":[{"range":{"start":
{"line": 0, "character": 23}, "end": {"line": 0, "character":
24}},"severity":2,"message":"Use nullptr (fix available)", "code":
"hicpp-use-nullptr", "source": "clang-tidy"},{"range":{"start": {"line": 0,
"character": 23}, "end": {"line": 0, "character":
24}},"severity":2,"message":"Use nullptr (fix available)", "code":
"modernize-use-nullptr", "source": "clang-tidy"}]}}}
+# CHECK: "id": 2,
----------------
could you also add another codeAction request with one of the codes missing?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63316/new/
https://reviews.llvm.org/D63316
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
