arsenm added a comment. In D62739#1543437 <https://reviews.llvm.org/D62739#1543437>, @arsenm wrote:
> In D62739#1536390 <https://reviews.llvm.org/D62739#1536390>, @yaxunl wrote: > > > My concern is that this essentially forcing user to add > > amdgpu_flat_work_group_size attribute to all kernels that are executed > > outside of (128,256). Potentially this can cause lots of regressions for > > existing OpenCL apps. I am not sure if it is feasible to force all OpenCL > > apps to make this change. Should we do some tests before making this change? > > > This is already the case. This is just moving it to the frontend. There's no > user observable change from this patch I do want to reduce the minimum bound to 1 at least (which is the default for graphics shaders), but that's a separate change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
