This revision was automatically updated to reflect the committed changes.
Closed by commit rL363372: [clangd] Don't maintain a list of c-family
extensions in vscode extension. (authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D63323?vs=204726&id=204747#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63323/new/
https://reviews.llvm.org/D63323
Files:
clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts
Index: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts
===================================================================
--- clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts
+++ clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts
@@ -72,18 +72,19 @@
// having a corresponding 'onLanguage:...' activation event in
package.json.
// However, VSCode does not have CUDA as a supported language yet, so we
// cannot add a corresponding activationEvent for CUDA files and clangd
will
- // *not* load itself automatically on '.cu' files. When any of the files
- // with other extensions are open, clangd will load itself and will also
- // work on '.cu' files.
- const filePattern: string = '**/*.{' +
- ['cpp', 'c', 'cc', 'cu', 'cxx', 'c++', 'm', 'mm',
- 'h', 'hh', 'hpp', 'hxx', 'inc'].join()
- + '}';
+ // *not* load itself automatically on '.cu' files.
+ const cudaFilePattern: string = '**/*.{' +['cu'].join()+ '}';
const clientOptions: vscodelc.LanguageClientOptions = {
- // Register the server for C/C++ files
- documentSelector: [{ scheme: 'file', pattern: filePattern }],
+ // Register the server for c-family and cuda files.
+ documentSelector: [
+ { scheme: 'file', language: 'c' },
+ { scheme: 'file', language: 'cpp' },
+ { scheme: 'file', language: 'objective-c'},
+ { scheme: 'file', language: 'objective-cpp'},
+ { scheme: 'file', pattern: cudaFilePattern },
+ ],
synchronize: !syncFileEvents ? undefined : {
- fileEvents: vscode.workspace.createFileSystemWatcher(filePattern)
+ // FIXME: send sync file events when clangd provides implemenatations.
},
initializationOptions: { clangdFileStatus: true },
// Do not switch to output window when clangd returns output
Index: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts
===================================================================
--- clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts
+++ clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts
@@ -72,18 +72,19 @@
// having a corresponding 'onLanguage:...' activation event in package.json.
// However, VSCode does not have CUDA as a supported language yet, so we
// cannot add a corresponding activationEvent for CUDA files and clangd will
- // *not* load itself automatically on '.cu' files. When any of the files
- // with other extensions are open, clangd will load itself and will also
- // work on '.cu' files.
- const filePattern: string = '**/*.{' +
- ['cpp', 'c', 'cc', 'cu', 'cxx', 'c++', 'm', 'mm',
- 'h', 'hh', 'hpp', 'hxx', 'inc'].join()
- + '}';
+ // *not* load itself automatically on '.cu' files.
+ const cudaFilePattern: string = '**/*.{' +['cu'].join()+ '}';
const clientOptions: vscodelc.LanguageClientOptions = {
- // Register the server for C/C++ files
- documentSelector: [{ scheme: 'file', pattern: filePattern }],
+ // Register the server for c-family and cuda files.
+ documentSelector: [
+ { scheme: 'file', language: 'c' },
+ { scheme: 'file', language: 'cpp' },
+ { scheme: 'file', language: 'objective-c'},
+ { scheme: 'file', language: 'objective-cpp'},
+ { scheme: 'file', pattern: cudaFilePattern },
+ ],
synchronize: !syncFileEvents ? undefined : {
- fileEvents: vscode.workspace.createFileSystemWatcher(filePattern)
+ // FIXME: send sync file events when clangd provides implemenatations.
},
initializationOptions: { clangdFileStatus: true },
// Do not switch to output window when clangd returns output
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
