rsandifo-arm marked 4 inline comments as done. rsandifo-arm added a comment.
Thanks for the review. In D62962#1534528 <https://reviews.llvm.org/D62962#1534528>, @jfb wrote: > How do these types mangle? At the moment, the mangling is only defined for the Itanium ABI, which uses `str(len(name)) + name` for the built-in type name (e.g. `__SVInt8_t`. This is implemented in https://reviews.llvm.org/D62960. ================ Comment at: test/Sema/sizeless-1.c:60 + (void)__atomic_is_lock_free(1, &local_int8); + (void)__atomic_always_lock_free(1, &local_int8); + ---------------- jfb wrote: > What do you expect these to return? Fixed to make this clearer. The types provide no compile-time alignment guarantees, so constant evaluation needs to make the most pessimistic assumption. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
