sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:734 + "ignored auto-triggered completion, preceding char did not match", + ErrorCode::RequestCancelled)); Server->codeComplete(Params.textDocument.uri.file(), Params.position, CCOpts, ---------------- this error code seems bogus, we should have a comment explaining that returning and empty list breaks vscode and any other error code breaks coc.nvim. (Might want to file a vscode or LSP bug - trigger char is a heuristic, if [] isn't the preferred way for a server to say "no" then we should spell it out, if it is then vscode is wrong) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62999/new/ https://reviews.llvm.org/D62999 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
