eugenis added inline comments.
================
Comment at: lib/CodeGen/CGExpr.cpp:2494
@@ +2493,3 @@
+ llvm::Value *ValidVtable = nullptr;
+ if (CheckAndAppendValidVtable) {
+ llvm::Value *AllVtables = llvm::MetadataAsValue::get(
----------------
samsonov wrote:
> This is really ugly. Why are you not passing it down in DynamicArgs? Is it
> performance penalty you don't want to pay if the check will not succeed? How
> large will it be?
Yes, I want this code to be on the failing side of the check.
This would cost about the same as the check itself, so I suspect it could
double the overhead.
Repository:
rL LLVM
http://reviews.llvm.org/D16823
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
