a_sidorin added a comment.
Hi Gabor,
The idea looks fine to me, but I have some questions inline.
================
Comment at: clang/lib/AST/ASTImporter.cpp:5109
} else { // ODR violation.
// FIXME HandleNameConflict
+ return make_error<ImportError>(ImportError::NameConflict);
----------------
Is this FIXME obsolete now?
================
Comment at: clang/lib/AST/ASTImporter.cpp:7823
+ auto Pos = ImportedDecls.find(FromD);
+ if (Pos != ImportedDecls.end()) {
+ // Import failed after the object was created.
----------------
I see the enabled test case, but does it cover the logic in this block?
================
Comment at: clang/lib/AST/ASTImporter.cpp:7851
+ if (!getImportDeclErrorIfAny(FromD)) {
+ // Error encountered for the first time.
+ // After takeError the error is not usable any more in ToDOrErr.
----------------
Is it possible to get this error more than once?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62373/new/
https://reviews.llvm.org/D62373
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
