a_sidorin added a comment. Hello Gabor, I have a few questions inline.
================ Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:124 + case DeclarationName::CXXConversionFunctionName: + return true; + ---------------- Should we check the equivalence of getCXXNameType() in such cases? ================ Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:127 + case DeclarationName::CXXDeductionGuideName: + return IsStructurallyEquivalent( + Name1.getCXXDeductionGuideTemplate()->getDeclName(), ---------------- Should we check the equivalence of the whole Name1.getCXXDeductionGuideTemplate() (with the template arguments)? ================ Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:147 + + return true; +} ---------------- llvm_unreachable()? ================ Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:163 + return IsStructurallyEquivalent(Context, DE1->getQualifier(), + DE2->getQualifier()); + } ---------------- Should we compare TemplateArgs (getTemplateArgs) somehow? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62329/new/ https://reviews.llvm.org/D62329 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
