ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM, thanks! ================ Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:38 " else ", statement(T)))); + Rule.Cases[0].Explanation = tooling::text("no explanation"); + return Rule; ---------------- NIT: this might be the first place people look at when writing the check, so we might want to provide a real explanation here. Something like `negate condition and revert then and else branches` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62340/new/ https://reviews.llvm.org/D62340 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits