aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM!
================ Comment at: clang/include/clang/Basic/Attr.td:297 def CUDA : LangOpt<"CUDA">; -def COnly : LangOpt<"CPlusPlus", 1>; +def COnly : LangOpt<"COnly", "!LangOpts.CPlusPlus">; def CPlusPlus : LangOpt<"CPlusPlus">; ---------------- This compiles? I would have assumed that it would have to be `def COnly : LangOpt<"COnly", [{!LangOpts.CPlusPlus}]>;` (If it compiles as-is, that's fine, I just wasn't aware that you could use string syntax for code blocks.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits