Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Please address the minor nitpicks suggested here in your final commit.
================
Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:16
+// -Builtins.def, containing builtins functions requiring special handling.
+// -opencl-c.h, containing OpenCL type definitions and builtins functions
+// which have few overloads.
----------------
I don't think we plan to modify `opencl-c.h` due to compatibility issues. I
think we should factor out functionality that will be required by both
`TableGen` mode and regular include mode into something like `opencl-common.h`.
================
Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:66
+//===----------------------------------------------------------------------===//
+// OpenCL/C classes for types
+//===----------------------------------------------------------------------===//
----------------
OpenCL/C -> OpenCL C
================
Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:106
+//===----------------------------------------------------------------------===//
+// OpenCL/C class for builtin functions
+//===----------------------------------------------------------------------===//
----------------
-> OpenCL C
================
Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:168
+//===----------------------------------------------------------------------===//
+// Definitions of OpenCL/C types
+//===----------------------------------------------------------------------===//
----------------
-> OpenCL C
================
Comment at: clang/test/SemaOpenCL/builtin-new.cl:18
+
+kernel void basic_extension(global uint* out) {
+ out[0] = get_sub_group_size();
----------------
basic_extension -> basic_subgroup
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60763/new/
https://reviews.llvm.org/D60763
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
