jyknight added a comment.

In D62268#1512672 <https://reviews.llvm.org/D62268#1512672>, @ldionne wrote:

> This LGTM.
>
> When I did the refactor, all the code was only using `-isysroot` (and never 
> accessing `--sysroot`), so I thought only `-isysroot` was relevant on Darwin. 
> Seems like I was wrong.


The isysroot argument to the cc1 compiler invocation got populated from both 
isysroot and --sysroot in the driver, so that's why the behavior changed here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62268/new/

https://reviews.llvm.org/D62268



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to