kadircet added inline comments.
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4135
+ !PotentialTemplateName.getAsIdentifierInfo()->getName().contains(
+ "function"))
+ return nullptr;
----------------
This looks cheesy, do we really want to perform this operation only for
templates with `"function"` in their names?
As discussed offline maybe perform this for any template with a
single(non-defaulted?) argument, or maybe even better perform a type-check as
suggested by you. But I believe there would be too many false positives with
the current state.
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4154
+ Results.getCodeCompletionTUInfo());
+ // [](<parameters>) {}
+ Completion.AddChunk(CodeCompletionString::CK_LeftBracket);
----------------
maybe also add a placeholder for captures?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62238/new/
https://reviews.llvm.org/D62238
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
