hans added inline comments.
================ Comment at: lib/Frontend/TextDiagnostic.cpp:768 if (Dir) { +#ifdef _WIN32 + SmallString<4096> DirName = Dir->getName(); ---------------- I think this requires a comment explaining why Windows is handled differently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59415/new/ https://reviews.llvm.org/D59415 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits