Szelethus marked 2 inline comments as done.
Szelethus added a comment.

If there's a cmake variable for fuchsia, Could you please try to add them here? 
(see inlines) I don't have access to that particular platform.


================
Comment at: 
cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt:4
+
+if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN))
+  target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE
----------------
```
if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN OR FUCHSIA))
```


================
Comment at: cfe/trunk/test/Analysis/plugins/SampleAnalyzer/CMakeLists.txt:4
+
+if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN))
+  target_link_libraries(SampleAnalyzerPlugin PRIVATE
----------------
Szelethus wrote:
> Is it possible that if we tweaked this line the error would go away?
```
if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN OR FUCHSIA))
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59464/new/

https://reviews.llvm.org/D59464



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to