theraven requested changes to this revision. theraven added inline comments. This revision now requires changes to proceed.
================ Comment at: lib/AST/ASTContext.cpp:6973 QualType PointeeTy = OPT->getPointeeType(); - if (!Options.EncodingProperty() && + if (getLangOpts().ObjCRuntime.isGNUFamily() && + !Options.EncodingProperty() && ---------------- Please can we at least make this check just for the GCC runtime? I'm not sure it's even needed there. I've previously had to write code that works around this and have always considered it a bug in GCC, rather than a feature that I'd like us to copy, so I'd also be happy with just deleting this code path entirely. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61974/new/ https://reviews.llvm.org/D61974 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits