Fair enough - since they're already there I don't feel super serious about converging on one (though I probably wouldn't've been in favor of adding a second spelling at the point it was proposed).
On Tue, May 14, 2019 at 8:03 AM <paul.robin...@sony.com> wrote: > > There's no practical difference. I view it as a matter of documentation of > intent, see my commit log comment for r360603. > > Arguably we could eliminate UNSUPPORTED and move all the expressions into > REQUIRES (appropriately negated), but I'm not sure that's a net win for > readability. > > --paulr > > > > From: David Blaikie [mailto:dblai...@gmail.com] > Sent: Monday, May 13, 2019 10:48 AM > To: Robinson, Paul > Cc: cfe-commits > Subject: Re: r360452 - Replace 'REQUIRES: nozlib' with '!zlib' because we > don't need two ways > > > > What's the practical difference between "UNSUPPORTED: foo" and "REQUIRES: > !foo"? (I see some of the fixes you've made go one way, some the other way) > > > > On Fri, May 10, 2019 at 11:30 AM Paul Robinson via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: probinson > Date: Fri May 10 11:32:53 2019 > New Revision: 360452 > > URL: http://llvm.org/viewvc/llvm-project?rev=360452&view=rev > Log: > Replace 'REQUIRES: nozlib' with '!zlib' because we don't need two ways > to say the same thing. > > Modified: > cfe/trunk/test/Driver/nozlibcompress.c > > Modified: cfe/trunk/test/Driver/nozlibcompress.c > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/nozlibcompress.c?rev=360452&r1=360451&r2=360452&view=diff > ============================================================================== > --- cfe/trunk/test/Driver/nozlibcompress.c (original) > +++ cfe/trunk/test/Driver/nozlibcompress.c Fri May 10 11:32:53 2019 > @@ -1,4 +1,4 @@ > -// REQUIRES: nozlib > +// REQUIRES: !zlib > > // RUN: %clang -### -fintegrated-as -gz -c %s 2>&1 | FileCheck %s > -check-prefix CHECK-WARN > // RUN: %clang -### -fintegrated-as -gz=none -c %s 2>&1 | FileCheck > -allow-empty -check-prefix CHECK-NOWARN %s > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
