philip.pfaffe accepted this revision. philip.pfaffe added a comment. This revision is now accepted and ready to land.
Nit aside, looks good! ================ Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:179 - bool runOnFunction(Function &F) override; - bool doInitialization(Module &M) override; + bool instrumentFunction(Function &F); + void initializeWithModule(Module &M); ---------------- There are some naming clashes here. In the other sanitizers these functions are called `sanitizeFunction` and `initializeModule`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61709/new/ https://reviews.llvm.org/D61709 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
