sammccall added a comment. My feedback would be:
- I definitely think more control over preserving line breaks would be useful. Actually preserving *blank* lines is an important property. If you see D60605 <https://reviews.llvm.org/D60605>, there are a lot of cases where clang-format wants to delete the line you just added. Maybe we can make `MaxEmptyLinesToKeep: 9999999` work in more cases. - I'm not convinced you need/want to preserve *all* line breaks, isn't it just one? (where the user pressed enter) - It's unclear why "extraformattingoptions" is needed, rather than just the usual formatting options, or some other parameter. It would be nice to avoid a new library entry point (overload) if possible. - as far as command-line interface goes, this definitely feels more like a flag than a new tool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53072/new/ https://reviews.llvm.org/D53072 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
