chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.
The file name of the test seems odd? How about `vectorize-loops.c`? I'd also
make it a C test and put it in `test/CodeGen` instead of a C++ test.
================
Comment at: test/CodeGenCXX/no-pragma-loop.cpp:7
+// CHECK-ENABLE-VECT: for.body:
+// CHECK-ENABLE-VECT: vector.body:
+
----------------
I'd check for an instruction on a vector type as the block labels aren't really
that stable.
Should be able to just check for something like:
```
// CHECK-LABEL: define @vectorize_loop_test {
// CHECK: mul <{{[0-9]+}} x double>
```
Or something...
Also, you'll want to explicitly pass a target triple here and require that
target to be registered so we're not flaky when the host target changes.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61617/new/
https://reviews.llvm.org/D61617
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
