rsmith accepted this revision.
rsmith marked an inline comment as done.
rsmith added a comment.
This revision is now accepted and ready to land.
Thank you, please go ahead and land this! (We'll need to parse and handle
//requires-clause//s here too, but that can wait for another patch.)
(Please feel free to send ~weekly pings if you're not getting code review
feedback; it's easy for things to get missed.)
================
Comment at: lib/AST/DeclPrinter.cpp:107-108
- void printTemplateParameters(const TemplateParameterList *Params);
+ void printTemplateParameters(const TemplateParameterList *Params,
+ bool OmitTemplateKW = false);
void printTemplateArguments(const TemplateArgumentList &Args,
----------------
hamzasood wrote:
> rsmith wrote:
> > Nit: I'd prefer splitting this into two functions (one that prints
> > 'template', calls the other, then prints a space, and the other to print
> > the actual template parameters) rather than passing a boolean flag.
> Do you reckon that the boolean flag is okay for
> `TemplateParameterList::print`? I've left this change for now until that has
> been decided.
This seems fine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D36527/new/
https://reviews.llvm.org/D36527
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
