[PATCH] D61274: [Sema][AST] Explicit visibility for OpenCL/CUDA kernels/variables

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added inline comments.


================
Comment at: lib/AST/Decl.cpp:738
+      (isa<FunctionDecl>(D) && D->hasAttr<CUDAGlobalAttr>()) ||
+      (isa<VarDecl>(D) && D->hasAttr<CUDADeviceAttr>())) {
+    Visibility Vis = LV.getVisibility();
----------------
yaxunl wrote:
> we also need this for `__constant__` variables.
And what about `__global` and `__constant` program scope variables in OpenCL?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61274/new/

https://reviews.llvm.org/D61274



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits