ahatanak added a comment.

In D61147#1479932 <https://reviews.llvm.org/D61147#1479932>, @rjmccall wrote:

> I would also recommend that you go fix the warning to never fire on virtual 
> C++ methods.


I tried building clang/llvm with  -Wunused-parameter turned on and there are 
lots of places where parameters are unused other than virtual functions, in 
particular template functions and non-template functions that are called by 
other template functions. So disabling the warning on C++ virtual functions is 
probably not enough in order to make this warning more useful.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61147/new/

https://reviews.llvm.org/D61147



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to