MaskRay added inline comments.
================ Comment at: clang-tools-extra/trunk/clangd/unittests/lit.cfg.in:1 +@LIT_SITE_CFG_IN_HEADER@ +# This is a shim to run the gtest unittests in ../unittests using lit. ---------------- thakis wrote: > thakis wrote: > > Every other LLVM project puts the lit.cfg.in for the unit tests in > > foo/test/Unit/lit.cfg.in. Any reason why clangd is different? > > > > Also, almost all LLVM projects call their lit.cfg lit.cfg.py and this file > > lit.cfg.py.in since it helps Windows. Can you rename the lit.cfg(.in) files > > you added to have .py in them please? > > > > Also, why did you merge the site.cfg.py.in file with the non-generated > > non-site file? This too is different from all other LLVM projects. > One consequence of these differences (except things being harder to > understand) is that running `bin/llvm-lit > ../llvm-project/clang-tools-extra/clangd/test` doesn't do anything, and > running a single test that way doesn't work either. This works fine for > individual llvm, clang, lld, clang-tools-extra tests and it used to work for > clangd tests. I know little about lit configurations but not being able to run a single test (`$build/bin/llvm-lit clangd/test/path/to/some/test`) seems a big downside.. (offtopic: compiler-rt tests have two modes: i386 and x86_64. I wonder if llvm-lit can run a test in the i386 mode (if it defaults to x86_64)) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
