[PATCH] D60912: MS ABI: handle inline static data member as template static data member

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

Thanks, I think there's another case to handle, though.



================
Comment at: lib/CodeGen/CGDeclCXX.cpp:471-473
+             (getTarget().getCXXABI().isMicrosoft() &&
+              D->isInlineSpecified() && D->isStaticDataMember() &&
+              getLangOpts().CPlusPlus17)) {
----------------
I think the whole second condition can be simplified to just 
`D->isIinlineSpecified()`. We have to consider plain inline global variables, 
not just static data members, as in:
```
int f();
inline int gvinit_inline = f();
int useit() { return gvinit_inline ; }
```


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60912/new/

https://reviews.llvm.org/D60912



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits