RKSimon added inline comments.
================ Comment at: lib/Headers/avx512bf16intrin.h:23 + +static __inline__ __m512bh __DEFAULT_FN_ATTRS512 +_mm512_cvtne2ps_pbh(__m512 __A, __m512 __B) { ---------------- All of these need proper doxygen based descriptions - see xmmintrin.h etc. for examples. ================ Comment at: test/CodeGen/avx512bf16-builtins.c:9 + // CHECK-LABEL: @test_mm512_cvtne2ps2bf16 + // CHECK: @llvm.x86.avx512bf16.cvtne2ps2bf16.512 + return _mm512_cvtne2ps_pbh(A, B); ---------------- add ret/arg types? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60552/new/ https://reviews.llvm.org/D60552 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits