a_sidorin accepted this revision.
a_sidorin added a comment.
I like the test even more than the change itself!
================
Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:49
+ // Bind(Zero)
+ Store StX0 =
+ StMgr.Bind(StInit, LX0, Zero).getStore();
----------------
This can fit one line.
================
Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:82
+ VariableBindConsumer(CompilerInstance &C) : ExprEngineConsumer(C) {}
+ ~VariableBindConsumer() override {}
+
----------------
Do we need this dtor declaration?
================
Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:93
+public:
+ VariableBindAction() {}
+ std::unique_ptr<ASTConsumer> CreateASTConsumer(CompilerInstance &Compiler,
----------------
`= default`? (Or it seems like we can remove it at all)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60742/new/
https://reviews.llvm.org/D60742
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
