Author: ygribov Date: Thu Jan 28 03:27:46 2016 New Revision: 259030 URL: http://llvm.org/viewvc/llvm-project?rev=259030&view=rev Log: Small refactor in isBeforeInTranslationUnit.
Differential Revision: http://reviews.llvm.org/D15804 Modified: cfe/trunk/lib/Basic/SourceManager.cpp Modified: cfe/trunk/lib/Basic/SourceManager.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/SourceManager.cpp?rev=259030&r1=259029&r2=259030&view=diff ============================================================================== --- cfe/trunk/lib/Basic/SourceManager.cpp (original) +++ cfe/trunk/lib/Basic/SourceManager.cpp Thu Jan 28 03:27:46 2016 @@ -2089,10 +2089,10 @@ bool SourceManager::isBeforeInTranslatio // Clear the lookup cache, it depends on a common location. IsBeforeInTUCache.clear(); - llvm::MemoryBuffer *LBuf = getBuffer(LOffs.first); - llvm::MemoryBuffer *RBuf = getBuffer(ROffs.first); - bool LIsBuiltins = strcmp("<built-in>", LBuf->getBufferIdentifier()) == 0; - bool RIsBuiltins = strcmp("<built-in>", RBuf->getBufferIdentifier()) == 0; + const char *LB = getBuffer(LOffs.first)->getBufferIdentifier(); + const char *RB = getBuffer(ROffs.first)->getBufferIdentifier(); + bool LIsBuiltins = strcmp("<built-in>", LB) == 0; + bool RIsBuiltins = strcmp("<built-in>", RB) == 0; // Sort built-in before non-built-in. if (LIsBuiltins || RIsBuiltins) { if (LIsBuiltins != RIsBuiltins) @@ -2101,8 +2101,8 @@ bool SourceManager::isBeforeInTranslatio // lower IDs come first. return LOffs.first < ROffs.first; } - bool LIsAsm = strcmp("<inline asm>", LBuf->getBufferIdentifier()) == 0; - bool RIsAsm = strcmp("<inline asm>", RBuf->getBufferIdentifier()) == 0; + bool LIsAsm = strcmp("<inline asm>", LB) == 0; + bool RIsAsm = strcmp("<inline asm>", RB) == 0; // Sort assembler after built-ins, but before the rest. if (LIsAsm || RIsAsm) { if (LIsAsm != RIsAsm) _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
