MaskRay added a comment. In D60409#1461579 <https://reviews.llvm.org/D60409#1461579>, @phosek wrote:
> Our Mac builders have started failing after this change with the following: > > [3145/3502] Building CXX object > tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o > FAILED: > tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o > /b/s/w/ir/cache/goma/client/gomacc /b/s/w/ir/k/cipd/bin/clang++ > -DCLANG_VENDOR="\"Fuchsia \"" -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS > -Itools/clang/tools/extra/clangd/tool > -I/b/s/w/ir/k/llvm-project/clang-tools-extra/clangd/tool > -I/b/s/w/ir/k/llvm-project/clang/include -Itools/clang/include > -I/usr/include/libxml2 -Iinclude -I/b/s/w/ir/k/llvm-project/llvm/include > -I/b/s/w/ir/k/llvm-project/clang-tools-extra/clangd/tool/.. > -Itools/clang/tools/extra/clangd/tool/.. -fPIC -fvisibility-inlines-hidden > -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra > -Wno-unused-parameter -Wwrite-strings -Wcast-qual > -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough > -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor > -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -fno-common > -Woverloaded-virtual -Wno-nested-anon-types -O3 -gline-tables-only -UNDEBUG > -fno-exceptions -fno-rtti -MD -MT > tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o > -MF > tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o.d > -o tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o > -c /b/s/w/ir/k/llvm-project/clang-tools-extra/clangd/tool/ClangdMain.cpp > > /b/s/w/ir/k/llvm-project/clang-tools-extra/clangd/tool/ClangdMain.cpp:474:22: > error: use of undeclared identifier 'newXPCTransport' > TransportLayer = newXPCTransport(); > ^ > 1 error generated. > > > I don't understand why since this change hasn't touched the failing line. It has been fixed by rCTE358103 <https://reviews.llvm.org/rCTE358103> Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60409/new/ https://reviews.llvm.org/D60409 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
