rnk added inline comments.
================
Comment at: lib/Driver/ToolChains/MSVC.cpp:493
C.getDriver().Diag(clang::diag::warn_drv_msvc_not_found);
+ linkPath = TC.GetProgramPath("link.exe");
+ }
----------------
amccarth wrote:
> The comment above explains one reason why we shouldn't use link.exe on the
> path.
>
> If it is an appropriate fallback, modify the comment or add another one here
> explaining why this is better than failing. I think you hit on it in the
> patch summary, but it should be captured in the code.
Right, and this code block is inside some crazy getenv check for USE_PATH_LINK,
so I think we don't want to do a path search here. Then again, I bet someone
added that because they wanted clang to just do a path search. I guess, there's
your workaround.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60094/new/
https://reviews.llvm.org/D60094
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
