apazos added inline comments.
================
Comment at: lib/Driver/ToolChains/Clang.cpp:1813
+ }
+ } else if (Arg *A = Args.getLastArg(options::OPT_G)) {
+ SmallDataLimit = A->getValue();
----------------
Why do you we need to set a default? It will cause the optimization to be on
now, and I thought we want to first prioritize the globals we want to consider
for the optimization.
I think you should check for msmall-data-limit flag occurring with G, fpic and
mcmodel flags and print warning in all cases.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57497/new/
https://reviews.llvm.org/D57497
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
